timeline: stringify the internal ID and allow setting a prefix to the internal ID #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to define a prefix later, to distinguish detached timelines from live timelines.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
==========================================
+ Coverage 83.55% 83.60% +0.05%
==========================================
Files 241 241
Lines 24910 24919 +9
==========================================
+ Hits 20813 20833 +20
+ Misses 4097 4086 -11 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be handy to distinguish IDs coming from different timelines, and this will be useful for the permalink PR, where the "main"/live timeline may not have a prefix, but detached timelines may have one. With something like that, the apps will be able to transition from a detached timeline to the new one, and having different internal IDs for the events mean that their UI frameworks will be able to notice the change.
Supports #3234.