Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginator: select how many events to retrieve during initial /context and pagination queries #3349

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Apr 22, 2024

Does what it says on the tin. Mostly test changes.

Supports #3234

@bnjbvr bnjbvr requested a review from a team as a code owner April 22, 2024 14:40
@bnjbvr bnjbvr requested review from Hywan and removed request for a team April 22, 2024 14:40
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.54%. Comparing base (289e2ac) to head (5966c5a).

Files Patch % Lines
crates/matrix-sdk/src/event_cache/paginator.rs 94.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3349   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         241      241           
  Lines       24889    24910   +21     
=======================================
+ Hits        20793    20812   +19     
- Misses       4096     4098    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr merged commit c471ee4 into main Apr 22, 2024
35 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/paginator-define-num-events branch April 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants