room-list: exclude non-joined rooms when filtering by rooms, people, unreads and favourites

[stefanceriu]

With the addition of experimental-room-list-with-unified-invites we now need to be more strict with what types of rooms we allow in the room list when applying filters.

[codecov]

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.61%. Comparing base (4398052) to head (e8427c4).

Files	Patch %	Lines
...x-sdk-ui/src/room_list_service/filters/category.rs	80.00%	1 Missing ⚠️
...-sdk-ui/src/room_list_service/filters/favourite.rs	75.00%	1 Missing ⚠️
...rix-sdk-ui/src/room_list_service/filters/unread.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3347   +/-   ##
=======================================
  Coverage   83.60%   83.61%           
=======================================
  Files         241      241           
  Lines       24863    24866    +3     
=======================================
+ Hits        20787    20791    +4     
+ Misses       4076     4075    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

Thanks for you work! I am however wondering if it's not better to add a join filter, just like the invite filter, and then use logic combinators like all(join, unread), it's seem more modular this way, thoughts?

Why am I proposing this? Because with this PR, we cannot use the unread, category and the favorite filter with invite (or later left maybe) anymore. It doesn't make a lot of sense for unread and favorite, but it makes sense for category.

[Hywan]

Can you update the comment please? Or better, let's have two fields? Actually I would prefer if we can split the logic in two different fields please 🙂.

[stefanceriu]

it's seem more modular this way, thoughts?

Yeah, that sounds like a great idea, don't know why I didn't think about it myself 🤦