timeline: simplify redaction and add documentation #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redaction was requiring the `RoomRedactionEventContent`, which was eventually unused in all the code paths; this removes it. Also adds lots of documentation for the different types of reaction that can happen in the timeline.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3344 +/- ##
==========================================
- Coverage 83.63% 83.61% -0.02%
==========================================
Files 241 241
Lines 24881 24848 -33
==========================================
- Hits 20808 20777 -31
+ Misses 4073 4071 -2 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/simplify-timeline-redaction
branch
from
9b5f2f0
to
08bfea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you know what the differences between a
TimelineEventKindRedaction,RedactedMessage, andLocalRedactionare? Now, with this brand new reverse-engineering fueled pull request, you'll do! Don't hesitate to take this one-in-a-lifetime opportunity to shine at Matrix-related events before it's too late!