sdk: move get_profile from Client to Account
#3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename existing `Account::get_profile` to `Account::get_current_user_profile` and reuse the new function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 236 236
Lines 24419 24419
=======================================
Hits 20423 20423
Misses 3996 3996 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Mar 19, 2024
poljar
requested changes
Mar 19, 2024
crates/matrix-sdk/src/account.rs
Outdated
| /// println!( | ||
| /// "You are '{:?}' with avatar '{:?}'", | ||
| /// profile.displayname, profile.avatar_url | ||
| /// ); | ||
| /// # anyhow::Ok(()) }; | ||
| /// ``` | ||
| pub async fn get_profile(&self) -> Result<get_profile::v3::Response> { | ||
| pub async fn get_current_user_profile(&self) -> Result<get_profile::v3::Response> { |
There was a problem hiding this comment.
I talked to some folks in the SDK team.
We agreed that we'd prefer this to be called: fetch_user_profile().
crates/matrix-sdk/src/account.rs
Outdated
| /// # Arguments | ||
| /// | ||
| /// * `user_id` the matrix id this function downloads the profile for | ||
| pub async fn get_profile(&self, user_id: &UserId) -> Result<get_profile::v3::Response> { |
There was a problem hiding this comment.
And this one should be called fetch_user_profile_of().
poljar
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Looks good, please just add a changelog entry like @andybalaam requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename existing
Account::get_profiletoAccount::get_current_user_profileand reuse the new function.Signed-off-by: