chore: upgrade uniffi-rs to latest commit #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samy Djemaï <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 236 236
Lines 24402 24402
=======================================
Hits 20416 20416
Misses 3986 3986 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thanks for the investigation and fix, lgtm.
@bmarty @ganfra @jmartinesp Can you check the Android bindings still work with this version of UniFFI please? Thanks!
jmartinesp
approved these changes
Mar 19, 2024
|
@SamyDjemai Sorry, I forgot to ask for a signoff, as requested in our contribution guidelines: are you happy editing your original message to add it after the fact, please? |
|
Sure @bnjbvr, I've updated my message :) Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/element-x-android#2346
When Element X ran on GrapheneOS, a fork of Android, with API Level 33, it crashed on startup because it tried to instantiate an
AndroidSystemCleaner, which is not supported. A pull request, mozilla/uniffi-rs#2036, was merged to avoid using aSystemCleaneron Android 13.Signed-off-by: Samy Djemaï [email protected]