-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add a workflow to verify the minimum supported Rust version #3228
Conversation
This is failing as expected since the current code requires Rust 1.76. I will merge a PR to update that before this one. |
3951a3c
to
cd58f54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3228 +/- ##
==========================================
- Coverage 83.66% 83.60% -0.06%
==========================================
Files 236 236
Lines 24402 24292 -110
==========================================
- Hits 20415 20309 -106
+ Misses 3987 3983 -4 ☔ View full report in Codecov by Sentry. |
Please feel free to just add a commit to this PR. |
I'd already done #3229 , and I feel like it's marginally better as a separate PR, so... |
Well it's more work, now you have to rebase this one onto main. |
dc99408
to
1e22700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run cargo update
by mistake, or did bumping the minimum version cause a change there? It seems the Cargo.lock
has hundreds of lines of changes...
I had to add a dependency, and it changed |
I undid the Cargo.lock changes and ran |
Thanks for checking, and in this case please ignore me :) (Tiny request if you're so inclined: could we use a workspace dependency for |
I am getting errors in
Any ideas why? |
I will do this in a different PR 👍 |
Revert the |
058ac7f
to
3d16d13
Compare
|
Just looking for a tick here if someone feels ready to do so. |
I'm happy to review, but there's one thing I'd like to try out before 👀 |
3d16d13
to
d474f6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #3224
Based on the recommendation at https://doc.rust-lang.org/cargo/guide/continuous-integration.html#verifying-rust-version