Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add a workflow to verify the minimum supported Rust version #3228

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Mar 18, 2024

@andybalaam andybalaam requested a review from a team as a code owner March 18, 2024 10:06
@andybalaam andybalaam requested review from Hywan and removed request for a team March 18, 2024 10:06
@andybalaam
Copy link
Contributor Author

This is failing as expected since the current code requires Rust 1.76. I will merge a PR to update that before this one.

@andybalaam andybalaam force-pushed the andybalaam/verify-min-supported-rust-version branch from 3951a3c to cd58f54 Compare March 18, 2024 10:18
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (32edfb1) to head (3d16d13).
Report is 1 commits behind head on main.

❗ Current head 3d16d13 differs from pull request most recent head d474f6a. Consider uploading reports for the commit d474f6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
- Coverage   83.66%   83.60%   -0.06%     
==========================================
  Files         236      236              
  Lines       24402    24292     -110     
==========================================
- Hits        20415    20309     -106     
+ Misses       3987     3983       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar
Copy link
Contributor

poljar commented Mar 18, 2024

This is failing as expected since the current code requires Rust 1.76. I will merge a PR to update that before this one.

Please feel free to just add a commit to this PR.

@andybalaam
Copy link
Contributor Author

Please feel free to just add a commit to this PR.

I'd already done #3229 , and I feel like it's marginally better as a separate PR, so...

@poljar
Copy link
Contributor

poljar commented Mar 18, 2024

Please feel free to just add a commit to this PR.

I'd already done #3229 , and I feel like it's marginally better as a separate PR, so...

Well it's more work, now you have to rebase this one onto main.

@andybalaam andybalaam force-pushed the andybalaam/verify-min-supported-rust-version branch 2 times, most recently from dc99408 to 1e22700 Compare March 18, 2024 14:28
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run cargo update by mistake, or did bumping the minimum version cause a change there? It seems the Cargo.lock has hundreds of lines of changes...

@andybalaam
Copy link
Contributor Author

Did you run cargo update by mistake, or did bumping the minimum version cause a change there? It seems the Cargo.lock has hundreds of lines of changes...

I had to add a dependency, and it changed Cargo.lock. Not sure why...

@andybalaam
Copy link
Contributor Author

I had to add a dependency, and it changed Cargo.lock. Not sure why...

I undid the Cargo.lock changes and ran cargo check just to make sure, and it did it again so I am fairly sure it wasn't some kind of fat-fingers...

@bnjbvr
Copy link
Member

bnjbvr commented Mar 18, 2024

Thanks for checking, and in this case please ignore me :)

(Tiny request if you're so inclined: could we use a workspace dependency for wiremock? Seems it's used in multiple places, and already with different versions 😨 )

@andybalaam
Copy link
Contributor Author

I am getting errors in tests / matrix-rust-components-swift:

Undefined symbols for architecture x86_64:
  "_SCDynamicStoreCopyProxies", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore11get_proxies17h30fbdd908736fcfcE in libmatrix_sdk_ffi.a(system_configuration-6049f0e21ad420f1.system_configuration.97e11328e4c9ed6d-cgu.0.rcgu.o)

Any ideas why?

@andybalaam
Copy link
Contributor Author

Thanks for checking, and in this case please ignore me :)

(Tiny request if you're so inclined: could we use a workspace dependency for wiremock? Seems it's used in multiple places, and already with different versions 😨 )

I will do this in a different PR 👍

@poljar
Copy link
Contributor

poljar commented Mar 18, 2024

I am getting errors in tests / matrix-rust-components-swift:

Undefined symbols for architecture x86_64:
  "_SCDynamicStoreCopyProxies", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore11get_proxies17h30fbdd908736fcfcE in libmatrix_sdk_ffi.a(system_configuration-6049f0e21ad420f1.system_configuration.97e11328e4c9ed6d-cgu.0.rcgu.o)

Any ideas why?

Revert the reqwest bump with cargo update -p reqwest --precise 0.11.20.

@andybalaam andybalaam force-pushed the andybalaam/verify-min-supported-rust-version branch from 058ac7f to 3d16d13 Compare March 18, 2024 15:39
@andybalaam
Copy link
Contributor Author

(Tiny request if you're so inclined: could we use a workspace dependency for wiremock? Seems it's used in multiple places, and already with different versions 😨 )

#3231

@andybalaam
Copy link
Contributor Author

Just looking for a tick here if someone feels ready to do so.

@bnjbvr
Copy link
Member

bnjbvr commented Mar 18, 2024

I'm happy to review, but there's one thing I'd like to try out before 👀

@bnjbvr bnjbvr requested review from bnjbvr and removed request for Hywan March 18, 2024 16:42
@bnjbvr bnjbvr changed the title Add a CI workflow to verify the minimum supported Rust version ci: Add a workflow to verify the minimum supported Rust version Mar 18, 2024
@bnjbvr bnjbvr force-pushed the andybalaam/verify-min-supported-rust-version branch from 3d16d13 to d474f6a Compare March 18, 2024 17:27
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bnjbvr bnjbvr enabled auto-merge (rebase) March 18, 2024 17:28
@bnjbvr bnjbvr merged commit b2c96b7 into main Mar 18, 2024
70 checks passed
@bnjbvr bnjbvr deleted the andybalaam/verify-min-supported-rust-version branch March 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project doesn't compile on v1.75
3 participants