crypto: Store TrackedUsers in MemoryStore #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
approved these changes
Mar 15, 2024
andybalaam
force-pushed
the
andybalaam/save-outbound-sessions-in-memorystore
branch
from
bcf31a6
to
486b6d6
Compare
andybalaam
force-pushed
the
andybalaam/store-trackedusers-in-memorystore
branch
from
9e4eda3
to
1cdf6c8
Compare
Base automatically changed from
andybalaam/save-outbound-sessions-in-memorystore
to
main
March 19, 2024 11:39
andybalaam
force-pushed
the
andybalaam/store-trackedusers-in-memorystore
branch
from
1cdf6c8
to
af83204
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 83.63% 83.63% -0.01%
==========================================
Files 236 236
Lines 24436 24439 +3
==========================================
+ Hits 20438 20440 +2
- Misses 3998 3999 +1 ☔ View full report in Codecov by Sentry. |
andybalaam
force-pushed
the
andybalaam/store-trackedusers-in-memorystore
branch
from
af83204
to
099c855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I am trying to get
MemoryStoreto pass thecryptostore_integration_tests, I need this store to hold on to the tracked users, when previously it didn't both.Applies on top of #3220
Part of my work on element-hq/element-web#26892