sdk: Check if server name points to homeserver during discovery #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <[email protected]>
…scovery Before, only URLs like `https://example.org` would be checked as a homeserver. Providing `example.org` will check if `https://example.org` is the URL of a homeserver. Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 236 236
Lines 24442 24444 +2
=======================================
+ Hits 20452 20454 +2
Misses 3990 3990 ☔ View full report in Codecov by Sentry. |
bnjbvr
reviewed
Mar 15, 2024
Signed-off-by: Kévin Commaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small first commit reintroduces
sanitize_server_namein the public API. In Fractal, we use it to validate the string in the input before allowing the user to trigger the discovery.The main commit changes a bit the discovery process: before, server names like
example.orgwould only be checked for the presence of a well-known, and only URLs likehttps://example.orgwould be checked as a homeserver. Now, providingexample.orgwill also check ifhttps://example.orgis the URL of a homeserver.Sadly I don't think it's possible to add tests for it as it would require to have a homeserver accessible via HTTPS.