feat(ui,ffi): Add a new experimental-room-list-with-unified-invites feature
#3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature. The idea of this patch is to explore the possibility to unify the `all_rooms` list with the `invites` list in `RoomListService`. Since this is entirely experimental, it's behind a new feature flag. The feature itself can be configured at runtime by using the new `SyncServiceBuilder::with_unified_invites_in_room_list` builder method, or directly with `RoomListService::new_with_unified_invites` constructor.
Hywan
requested review from
poljar and
stefanceriu
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 232 232
Lines 24005 24006 +1
=======================================
+ Hits 20127 20129 +2
+ Misses 3878 3877 -1 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this patch is to explore the possibility to unify the
all_roomslist with theinviteslist inRoomListService. Since this is entirely experimental, it's behind a new feature flag. The feature itself can be configured at runtime by using the newSyncServiceBuilder::with_unified_invites_in_room_listbuilder method, or directly withRoomListService::new_with_unified_invitesconstructor.