ffi: add previous power levels to OtherState::RoomPowerLevels
#3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
jme/add-previous-power-levels-data-to-ffi-power-level-content
branch
from
8083402
to
40f5fa3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 232 232
Lines 23985 23985
=======================================
Hits 20109 20109
Misses 3876 3876 ☔ View full report in Codecov by Sentry. |
This is needed to be able to diff between increases and decreases of power levels.
jmartinesp
force-pushed
the
jme/add-previous-power-levels-data-to-ffi-power-level-content
branch
from
40f5fa3
to
ead2e14
Compare
bnjbvr
approved these changes
Mar 8, 2024
| FullContent::Original { content, prev_content } => { | ||
| power_level_user_changes(content, prev_content) | ||
| previous = prev_content.as_ref().map(|prev_content| { |
There was a problem hiding this comment.
style nit: can you have each branch return a Self::RoomPowerLevels immediately, instead of having two temporary variables? it would read slightly more straightforward.
There was a problem hiding this comment.
Sure, I just did it this way to not repeat too much code.
bnjbvr
reviewed
Mar 8, 2024
bnjbvr
deleted the
jme/add-previous-power-levels-data-to-ffi-power-level-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to diff between increases and decreases of power levels ("user Alice was promoted Admin", etc.).
Signed-off-by: