crypto: Break up the expiration tests for clarity #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
==========================================
- Coverage 83.85% 83.85% -0.01%
==========================================
Files 232 232
Lines 24004 24004
==========================================
- Hits 20129 20128 -1
- Misses 3875 3876 +1 ☔ View full report in Codecov by Sentry. |
andybalaam
force-pushed
the
andybalaam/break-up-expiration-tests
branch
from
1a55544
to
3c1e28e
Compare
poljar
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the way for me to add a feature flag making
rotation_period_ms's enforced minimum be turn-off-able via a feature flag (which is needed for matrix-org/complement-crypto#17).