timeline: integrate the event's cache backpagination into the timeline #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
ec-backpagination-into-timeline
branch
from
9b25278
to
60f5fc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
=======================================
Coverage 83.74% 83.74%
=======================================
Files 235 235
Lines 24223 24147 -76
=======================================
- Hits 20286 20223 -63
+ Misses 3937 3924 -13 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Mar 14, 2024
| /// items. | ||
| /// | ||
| /// Private because it's not needed by `TimelineEventHandler`. | ||
| back_pagination_tokens: VecDeque<(OwnedEventId, String)>, |
| ); | ||
| // fall through and continue the loop | ||
| } | ||
| let mut token = |
…rs file No changes in behavior, just pure code motion.
bnjbvr
force-pushed
the
ec-backpagination-into-timeline
branch
from
60f5fc7
to
ce8aa3b
Compare
bnjbvr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #3195 to make use of the new event cache's backpagination capabilities in the timeline code.