sdk&ffi: server unstable features support for MSC4028 #3192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
==========================================
+ Coverage 83.81% 83.83% +0.01%
==========================================
Files 232 232
Lines 23965 23984 +19
==========================================
+ Hits 20087 20106 +19
Misses 3878 3878 ☔ View full report in Codecov by Sentry. |
Signed-off-by: hanadi92 <[email protected]>
Signed-off-by: hanadi92 <[email protected]>
hanadi92
force-pushed
the
feat-server-unstable-features-support
branch
from
f78838c
to
175fae5
Compare
| /// Check whether [MSC 4028 push rule][rule] is enabled on the homeserver. | ||
| /// | ||
| /// [rule]: https://github.com/matrix-org/matrix-spec-proposals/blob/giomfo/push_encrypted_events/proposals/4028-push-all-encrypted-events-except-for-muted-rooms.md | ||
| pub async fn can_homeserver_push_encrypted_event_to_device(&self) -> bool { |
There was a problem hiding this comment.
There's a bit of logic here, and I think that this could be useful for other clients. Could this method go to the SDK, next to unstable_features, please? (and add a test for it too 🙏)
There was a problem hiding this comment.
of course! good hint. let me know if what I pushed goes in the direction of ur suggestion 👍
| @@ -90,6 +90,7 @@ pub struct ClientBuilder { | |||
| request_config: RequestConfig, | |||
| respect_login_well_known: bool, | |||
| server_versions: Option<Box<[MatrixVersion]>>, | |||
| unstable_features: Option<BTreeMap<String, bool>>, | |||
There was a problem hiding this comment.
This is unused in ClientBuilder, and can be removed. :-)
Co-authored-by: Benjamin Bouvier <[email protected]> Signed-off-by: Hanadi <[email protected]>
Signed-off-by: hanadi92 <[email protected]>
Signed-off-by: hanadi92 <[email protected]>
Signed-off-by: hanadi92 <[email protected]>
Signed-off-by: hanadi92 <[email protected]>
|
Thanks for the review! Changes are made accordingly. Let me know what you think about them :) I think the Code Coverage is breaking on a non-related issue. |
Signed-off-by: Benjamin Bouvier <[email protected]>
@bnjbvr Thanks a lot for taking the time in general and doing those changes! |
Fixes #3191
Allows support for fetching the unstable_features from
/_matrix/clients/versions.Specifically, to be used for checking the state of org.matrix.msc4028 through ffi to the clients.
P.S. ^ I can split them into two PRs if necessary.
Signed-off-by: @hanadi92