Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for m.call.invite events in the timeline and as a last room message #3181

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

stefanceriu
Copy link
Member

Prompted by element-hq/element-x-ios#1837

This PR exposes m.call.invite events on the Timeline and as a latest Room message. It will allow the client to render them and inform the user accordingly.

@stefanceriu stefanceriu requested a review from a team as a code owner March 4, 2024 10:59
@stefanceriu stefanceriu requested review from bnjbvr and removed request for a team March 4, 2024 10:59
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/matrix-sdk-base/src/client.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/sliding_sync.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 83.83%. Comparing base (4b711e4) to head (dc09e98).
Report is 1 commits behind head on main.

❗ Current head dc09e98 differs from pull request most recent head d9b4623. Consider uploading reports for the commit d9b4623 to get more accurate results

Files Patch % Lines
...trix-sdk-ui/src/timeline/event_item/content/mod.rs 0.00% 6 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/event_handler.rs 0.00% 2 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3181      +/-   ##
==========================================
- Coverage   83.85%   83.83%   -0.03%     
==========================================
  Files         232      232              
  Lines       23941    23952      +11     
==========================================
+ Hits        20076    20079       +3     
- Misses       3865     3873       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu
Copy link
Member Author

Noice, thanks for the review! 🙌

Feel free to merge it whenever you get around to it.

@bnjbvr bnjbvr merged commit e4be216 into main Mar 4, 2024
32 checks passed
@bnjbvr bnjbvr deleted the stefan/callInviteEvents branch March 4, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants