Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codecov action to v4 #3175

Merged
merged 1 commit into from
Mar 4, 2024
Merged

ci: update codecov action to v4 #3175

merged 1 commit into from
Mar 4, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Feb 29, 2024

https://github.com/codecov/codecov-action/tree/v4?tab=readme-ov-file#v4-release

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

Let's see if it helps with forks.

@bnjbvr bnjbvr requested a review from a team as a code owner February 29, 2024 10:47
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team February 29, 2024 10:47
@bnjbvr bnjbvr enabled auto-merge (rebase) February 29, 2024 16:56
@bnjbvr bnjbvr disabled auto-merge March 1, 2024 11:39
@bnjbvr bnjbvr closed this Mar 1, 2024
@bnjbvr bnjbvr reopened this Mar 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (8392ef0) to head (7c3ede7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3175   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         232      232           
  Lines       23938    23938           
=======================================
  Hits        20074    20074           
  Misses       3864     3864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr enabled auto-merge (rebase) March 1, 2024 11:56
@jmartinesp
Copy link
Contributor

jmartinesp commented Mar 1, 2024

I think you probably need to add the codecov token: element-hq/element-x-android@8ce7ae6. You can find it in Codecov's setting page.

@bnjbvr
Copy link
Member Author

bnjbvr commented Mar 1, 2024

@bnjbvr bnjbvr closed this Mar 1, 2024
auto-merge was automatically disabled March 1, 2024 14:34

Pull request was closed

@bnjbvr bnjbvr reopened this Mar 1, 2024
@bnjbvr bnjbvr closed this Mar 4, 2024
@bnjbvr bnjbvr reopened this Mar 4, 2024
@jmartinesp
Copy link
Contributor

Maybe rebase the code so the codecov flow runs? Closing/opening doesn't seem to be doing anything.

@bnjbvr
Copy link
Member Author

bnjbvr commented Mar 4, 2024

Oh well, I was hoping it was a fluke that would have passed over the weekend, but it doesn't seem to be. I think we should escalate this to the support team of codecov, if it happens again, because right now most of our pull requests are blocked.

@bnjbvr bnjbvr merged commit 74727e5 into main Mar 4, 2024
32 checks passed
@bnjbvr bnjbvr deleted the update-codecov4 branch March 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants