-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update codecov action to v4 #3175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 232 232
Lines 23938 23938
=======================================
Hits 20074 20074
Misses 3864 3864 ☔ View full report in Codecov by Sentry. |
I think you probably need to add the codecov token: element-hq/element-x-android@8ce7ae6. You can find it in Codecov's setting page. |
Ah, it seems we're passing it here already: https://github.com/matrix-org/matrix-rust-sdk/pull/3175/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6R118 |
Maybe rebase the code so the |
Oh well, I was hoping it was a fluke that would have passed over the weekend, but it doesn't seem to be. I think we should escalate this to the support team of codecov, if it happens again, because right now most of our pull requests are blocked. |
https://github.com/codecov/codecov-action/tree/v4?tab=readme-ov-file#v4-release
Let's see if it helps with forks.