ffi: expose the notification settings #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 167 167
Lines 17748 17748
=======================================
Hits 13635 13635
Misses 4113 4113 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Jul 7, 2023
bindings/matrix-sdk-ffi/src/api.udl
Outdated
|
|
||
| callback interface NotificationSettingsDelegate { | ||
| void settings_did_change(); | ||
| }; |
There was a problem hiding this comment.
Missing newline at the end. @jplatte am I imagining things or can we now define callback interfaces via proc macros?
There was a problem hiding this comment.
We can :)
#[uniffi::export(callback_interface)]
trait NotificationSettingsDelegate { /* ... */ }There was a problem hiding this comment.
Right, let's do that then. Thanks.
There was a problem hiding this comment.
Oh nice. Ok, I've updated the branch.
poljar
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last step of the #1959 implementation.
It exposes the
notification_settingscrate to update notification settings for a room, and to define whether certain predefined push rules are enabled.A
NotificationSettingsDelegatecan be defined to notify the client application each time push rules are updated.