Skip to content

Commit

Permalink
Merge branch 'main' into dehydrated_flag
Browse files Browse the repository at this point in the history
  • Loading branch information
uhoreg committed Mar 16, 2024
2 parents 8019bbf + 876d323 commit cd245b5
Show file tree
Hide file tree
Showing 155 changed files with 8,943 additions and 2,826 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
SLIDING_SYNC_PROXY_URL: "http://localhost:8118"

- name: Upload to codecov.io
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
# Work around frequent upload errors, for runs inside the main repo (not PRs from forks).
# Otherwise not required for public repos.
Expand Down
1 change: 1 addition & 0 deletions .typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ sing = "sign"
singed = "signed"
singing = "signing"
Nd = "Nd"
ratatui = "ratatui"

[files]
extend-exclude = [
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ bisections, helping identifying which commit introduced a regression.

A *good commit message* should be composed of:

- a hint to which area/feature is related by the commit
- a prefix to indicate which area/feature is related by the commit
- a short description that would give sufficient context for a reviewer to guess what the commit is
about.

Expand All @@ -57,7 +57,8 @@ Examples of good commit messages:
- “read_receipts: Store receipts locally, fixing #12345

A *proper PR title* would be a one-liner summary of the changes in the PR, following the
same guidelines of a good commit message.
same guidelines of a good commit message, including the area/feature prefix. Something like
`FFI: Allow logs files to be pruned.` would be a good PR title.

(An additional bad example of a bad PR title would be `mynickname/branch name`, that is, just the
branch name.)
Expand Down
Loading

0 comments on commit cd245b5

Please sign in to comment.