feat(dehydration): support for dehydration key and storage #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
previously requested changes
Dec 16, 2024
richvdh
reviewed
Dec 17, 2024
andybalaam
approved these changes
Dec 20, 2024
| version = "0.8.0" | ||
| source = "git+https://github.com/matrix-org/matrix-rust-sdk?branch=release-for-crypto-wasm-12#37c17cf854a70fe6f719c7fde49a6b0e4402988f" | ||
| version = "0.9.0" | ||
| source = "git+https://github.com/matrix-org/matrix-rust-sdk#b18100228e0456973d56d4ac6a58caf30b17bd8d" |
There was a problem hiding this comment.
This will have a conflict with #184 but you can just keep your changes and ignore that.
Cargo.toml
Outdated
| matrix-sdk-qrcode = { git = "https://github.com/matrix-org/matrix-rust-sdk", optional = true, branch="release-for-crypto-wasm-12" } | ||
| matrix-sdk-common = { git = "https://github.com/matrix-org/matrix-rust-sdk", features = ["js"] } | ||
| matrix-sdk-indexeddb = { git = "https://github.com/matrix-org/matrix-rust-sdk", default-features = false, features = ["e2e-encryption"] } | ||
| matrix-sdk-qrcode = { git = "https://github.com/matrix-org/matrix-rust-sdk", optional = true } |
There was a problem hiding this comment.
This does the same as #184 so hopefully no conflict?
Update matrix-sdk to 0.9.0
BillCarsonFr
force-pushed
the
valere/dehydration_key_bindings
branch
from
38bf441 to
33ee915
Compare
BillCarsonFr
commented
Dec 20, 2024
| @@ -1,5 +1,13 @@ | |||
| # UNRELEASED | |||
|
|
|||
| **BREAKING CHANGES** | |||
|
|
|||
| - Update matrix-rusk-sdk to `0.9.0`. | |||
There was a problem hiding this comment.
@andybalaam Should I use a git hash here too? even it is this actual tag, or link the tag?
There was a problem hiding this comment.
I think what you have is sufficient.
richvdh
reviewed
Jan 6, 2025
Comment on lines
+8
to
+9
| `DehydratedDevices.keysForUpload` and `DehydratedDevices.rehydrate` now use the `DehydratedDeviceKey` as parameter | ||
| instead of a raw UInt8Array.Use `DehydratedDeviceKey::createKeyFromArray` to migrate. |
There was a problem hiding this comment.
Sorry, a belated review:
- I think this point about
keysForUploadandrehydrateshould be a separate bullet point - The other points ("Update matrix-rusk-sdk to
0.9.0" and "Expose new API") aren't breaking changes so should be above the "BREAKING CHANGES" header (see matrix-sdk-crypto-wasm v12.0.0, for example) - It would be good to link to this pr for the changes (see lots of other entries in the changelog, for example)
- There are a number of typos on line 9. It should be:
instead of a raw `UInt8Array`. Use `DehydratedDeviceKey.createKeyFromArray` to migrate.
There was a problem hiding this comment.
[suggest fixing these as part of #187]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Depends on matrix-org/matrix-rust-sdk#4399