Revert "Fix room state being updated with old (now overwritten) state and emitting for those updates. (#4242)" #4532
+3
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those changes haven't landed yet and this is a breaking change as a parameter is being removed, it'd need to either be bundled into the same breaking release as the state_after stuff or need a deprecation period |
|
Where even was isStartTimelineState ever true? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 957329b.
@hughns @t3chguy
With the resent state_after changes this seems to not be required anymore right?
Checklist
public/exportedsymbols have accurate TSDoc documentation.