Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant type arguments in function call #4507

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

AndrewFerr
Copy link
Member

as the types can be deduced by the function arguments.

Signed-off-by: Andrew Ferrazzutti [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

as the types can be deduced by the function arguments.
@AndrewFerr
Copy link
Member Author

This might be needed to fix CI for element-hq/element-web#28357.

@t3chguy
Copy link
Member

t3chguy commented Nov 11, 2024

Merging with the hope on un-breaking develop CI.

@t3chguy t3chguy added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 4c53836 Nov 11, 2024
31 checks passed
@t3chguy t3chguy deleted the af/remove-redundant-type-args branch November 11, 2024 11:36
AndrewFerr added a commit to AndrewFerr/element-web that referenced this pull request Nov 11, 2024
github-merge-queue bot pushed a commit to element-hq/element-web that referenced this pull request Nov 11, 2024
* Let widget driver send error details

* Match new widget API types

* Don't @link across packages

in case web documentation generation disallows it.

* Update matrix-widget-api

* Update matrix-js-sdk

Include matrix-org/matrix-js-sdk#4507 to fix playwright CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants