Replace usages of global with globalThis
#4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of a linter to protect against regression here? |
Good idea! Let's have a look. |
t3chguy
reviewed
Oct 31, 2024
t3chguy
approved these changes
Oct 31, 2024
|
(N.B. leaving branch active for the moment as we're depending on it to unbreak some applications, once the next RC comes out this can be pruned) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4450
This should solve the problem with various bundlers (Vite etc) not being happy about the usage of
global, withglobalThis. All modern environments support this https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis, so it's a safe change.