KeyBackup: Disable signalling remaining keys to upload count #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
valere/element-r/send_perf_improvement
branch
from
12a3cb9
to
b78635c
Compare
BillCarsonFr
commented
Jan 17, 2024
| @@ -342,20 +342,29 @@ export class RustBackupManager extends TypedEventEmitter<RustBackupCryptoEvents, | |||
|
|
|||
| if (!request || this.stopped || !this.activeBackupVersion) { | |||
| logger.log(`Backup: Ending loop for version ${this.activeBackupVersion}.`); | |||
| if (!request) { | |||
| // nothing more to upload | |||
| this.emit(CryptoEvent.KeyBackupSessionsRemaining, 0); | |||
There was a problem hiding this comment.
Some test relies on this event to be fired at the end of the backup loop.
There was a problem hiding this comment.
this comment should probably be in the code, not the PR.
t3chguy
approved these changes
Jan 17, 2024
richvdh
approved these changes
Jan 17, 2024
|
Closing in favor of #4015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/element-web#26783 (comment)
Keys count performance can be pretty bad on some configurations (big database in FF).
For now we disable signalling the remaining key count to upload on rust crypto. (used by react sdk
SecureBackupPanel.tsxto provide some feedback).Note for reviewer:
I considered caching the count by only doing it when the backup loop is started.
The problem is that at the end of each sync you might receive some new keys and that could start a backup loop, meaning that the send performances could be degraded after each sync.
So for now, it's just disabled until we improve the store performances (count shouldn't take 10s of seconds)
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.