Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for the ReceiptAccumulator #3326

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Tests for the ReceiptAccumulator #3326

merged 1 commit into from
Apr 27, 2023
+171 −0

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Apr 27, 2023 •
edited by github-actions bot
Loading

Part of element-hq/element-web#24629

Set up some basic unit tests before we fix the actual bug and write tests that validate that.

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label Apr 27, 2023
@andybalaam andybalaam marked this pull request as ready for review April 27, 2023 08:58
@andybalaam andybalaam requested a review from a team as a code owner April 27, 2023 08:58
weeman1337
weeman1337 reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accumulator has a special handling of main thread events. In my opinion tests should cover this.

@andybalaam
Copy link
Contributor Author

The accumulator has a special handling of main thread events. In my opinion tests should cover this.

That's a bug I am about to fix. I'd prefer not to "lock down" the wrong behaviour then change the test later, but if you prefer that style I can do it.

@andybalaam andybalaam added this pull request to the merge queue Apr 27, 2023
Merged via the queue into develop with commit 2ebcda2 Apr 27, 2023
@andybalaam andybalaam deleted the andybalaam/tests-for-receipt-accumulator branch April 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @weeman1337