Factor out ReceiptAccumulator #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/factor-out-receipt-accumulator
branch
from
a393d28
to
6bc9128
Compare
andybalaam
force-pushed
the
andybalaam/factor-out-receipt-accumulator
branch
from
6bc9128
to
ef22653
Compare
|
Added @weeman1337 as a potential reviewer |
weeman1337
previously requested changes
Apr 26, 2023
| @@ -43,6 +44,12 @@ export interface IMinimalEvent { | |||
| unsigned?: IUnsigned; | |||
| } | |||
|
|
|||
| export interface AccumulatedReceipt { | |||
There was a problem hiding this comment.
Looks like this belongs to the ReceiptAccumulator and should eventually be moved to the receipt-accumulator module?
There was a problem hiding this comment.
Fixed in next PR: #3320
|
Thank you @weeman1337 - I will address all your comments in my next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24629
In order to allow us to write simple unit tests, factor out the part of the sync accumulator that does receipt handling. Later changes may well make this more self-contained. This change is intended to be simple enough that we can convince ourselves by examining it that it has the same behaviour as before.
This code is performance-critical, so I added a couple of tests. When I increased the
testSizein those tests to 10 million and 1 million, I got these results:With the old code:
With the new code:
So this change appears to slow us slightly when we have lots of redundant receipts, and speed us up when we have lots of receipts that we want to keep around.
I expect the speed changes are due to the use of a
Mapinstead of an object.I think the this change is acceptable, and I think using a Map is better generally, but am interested in others' opinions.
This change is marked as an internal change (Task), so will not be included in the changelog.