Aggregations store #659
Merged
Aggregations store #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we have Because of gappy syncs, we cannot keep aggregated data in-sync
manuroe
force-pushed
the
aggregations_store
branch
from
2637e38
to
77f67cf
Compare
| @property (nonatomic) NSString *roomId; | ||
|
|
||
| // eventId -> changes | ||
| @property (nonatomic) void (^block)(NSDictionary<NSString*, MXReactionCountChange*> *changes); |
There was a problem hiding this comment.
Block property should use copy attribute. More information here.
There was a problem hiding this comment.
Maybe we could also use a more explicit name like notificationBlock .
SBiOSoftWhare
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-ios#2392
Add a store implemented in realm and a data update mechanism.
All tests now pass.