Helm: Adding existingSecret.registation and existingSecret.passkey; Always store registration and passkey data in a Kubernetes secret
#962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store registration and passkey data in a Kubernetes secret; use projected volume to ensure all data in one directory Signed-off-by: jessebot <[email protected]>
jessebot
force-pushed
the
add-existing-secret-functionality
branch
from
6179624
to
c073b97
Compare
|
I guess I could have the standard config also possible to come from an existing Secret, as it may have data such as client_secret for github oauth? 🤔 |
mikemrm
added a commit
to mikemrm/matrix-org-matrix-hookshot
that referenced
this pull request
Sep 22, 2024
This change allows for config files to be sourced from a secret rather than a config map as these configs may have sensitive data. In addition to being able to source the config from a secret, the `extraContainerVolumeMounts` option was added which allows for mounting additional volumes defined in `extraContainerVolumes`, such mounting a passkey file secret. This also solves the same issue in a slightly different way from pr matrix-org#962 Signed-off-by: Mike Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for the helm chart and adds the following:
existingSecret.registationandexistingSecret.passkeyregistration.yml,passkey,pem, andconfig.ymlall get mounted to the same directoryFixes #835