Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing/removing multipart Slack messages #782

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Commits on Mar 29, 2024

  1. Use correct Slack ghosts to redact messages sent from Slack

    This makes us the original sender's intent to redact messages,
    so that we do not require an elevated PL to handle message deletion.
    tadzik committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d3a719d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2443e46 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    dd11c2a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Refactor message deletion; fallback to using our bot if we can't dete…

    …rmine a more fitting user
    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b4f2911 View commit details
    Browse the repository at this point in the history
  2. Formalize our one-to-many relationship between Slack and Matrix events

    We may produce multiple Matrix events per Slack events, if the Slack events contains text with attachments.
    This should have been forbidden with a DB constraint, but for some reason it happened regardless.
    
    This updates the constraint to match reality, differentiating Matrix events by the type of incoming Slack event.
    For backwards compatibility reasons getEventBySlackId() returns the "main" Matrix event.
    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0fe144d View commit details
    Browse the repository at this point in the history
  3. Add forgotten DB migration

    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0f2f989 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'tadzik/matrix-orggh-766/fix-message-redaction' into tad…

    …zik/one-to-many-events
    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bc4e019 View commit details
    Browse the repository at this point in the history
  5. Be more careful when dropping incoming messages

    Messages with a message_changed will have the same `ts` as the original message, but a different `event_ts`.
    We now check both when considering whether or not to drop a message, and log our reasons regardless.
    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a4fe71c View commit details
    Browse the repository at this point in the history
  6. Support removing attachments from Slack messages

    We now track which attachments was linked to which Matrix message,
    and support both removing them individually and dropping the whole event "tree".
    tadzik committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ae509b0 View commit details
    Browse the repository at this point in the history