Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring substitutions #517

Open
Cadair opened this issue Sep 28, 2020 · 1 comment
Open

Refactoring substitutions #517

Cadair opened this issue Sep 28, 2020 · 1 comment
Labels
hacktoberfest Good issues for people to tackle as part of hacktoberfest substitutions An issue relating to translation of event content between Slack and Matrix. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. Z-Good-First-Issue Good for newcomers

Comments

@Cadair
Copy link
Collaborator

Cadair commented Sep 28, 2020 •
edited
Loading

The bridge transforms messages in both directions to account for differences in the two platforms.

Currently these substitutions are largely in our substitutions.ts file however the code to translate slack mentions and rooms to matrix isn't in the substitutions file although it should be.

Since the last time the substitutions code has been refactored a specialist slack <> matrix library has been developed: https://github.com/Sorunome/matrix-slack-parser this issue is to track the migration of this bridge to using that library for all the translations.

This requires implementing all the callbacks that the library requires and then rewriting substitutions to use the parser library.

This issue could address all the issues labelled substitutions this includes #461 #400 #370 #357 #342 #327 #318 #315
@Cadair Cadair changed the title Refactoring subsitutions Refactoring substitutions Sep 28, 2020
@Cadair
Copy link
Collaborator Author

Cadair commented Sep 28, 2020

A stale attempt at this migration is here: #376

@Cadair Cadair added enhancement hacktoberfest Good issues for people to tackle as part of hacktoberfest labels Sep 28, 2020
@Half-Shot Half-Shot mentioned this issue Sep 28, 2020
Open
@Cadair Cadair mentioned this issue Oct 1, 2020
Closed
@Cadair Cadair added the substitutions An issue relating to translation of event content between Slack and Matrix. label Apr 7, 2021
@jaller94 jaller94 added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. Z-Good-First-Issue Good for newcomers and removed enhancement labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Good issues for people to tackle as part of hacktoberfest substitutions An issue relating to translation of event content between Slack and Matrix. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. Z-Good-First-Issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cadair @jaller94