Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack message can fail to bridge if transforming a channel mention fails #524

Closed
Half-Shot opened this issue Sep 30, 2020 · 2 comments · Fixed by #525
Closed

Slack message can fail to bridge if transforming a channel mention fails #524

Half-Shot opened this issue Sep 30, 2020 · 2 comments · Fixed by #525
Labels
substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Half-Shot
Copy link
Contributor

The bridge will try to fetch m.room.canonical_alias state for the room mentioned (in order to get the right alias), and if it fails to get the event then the code will throw and subsequently fail to bridge the message. This is obviously not ideal, and we should fall back to textual representation.
@Half-Shot Half-Shot added the bug label Sep 30, 2020
@Cadair Cadair added the substitutions An issue relating to translation of event content between Slack and Matrix. label Oct 1, 2020
@Cadair
Copy link
Collaborator

Cadair commented Oct 1, 2020

Should also be fixed by #517

@Half-Shot Half-Shot mentioned this issue Oct 1, 2020
Merged
@Half-Shot
Copy link
Contributor Author

I've fixed this one now because it's impacting enough folks.

@jaller94 jaller94 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not fail to bridge slack message if an alias doesn't exist matrix-org/matrix-appservice-slack
3 participants
@Cadair @Half-Shot @jaller94