Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M->S messages get the first newline eaten #342

Open
auscompgeek opened this issue Dec 22, 2019 · 5 comments
Open

M->S messages get the first newline eaten #342

auscompgeek opened this issue Dec 22, 2019 · 5 comments
Labels
hacktoberfest Good issues for people to tackle as part of hacktoberfest substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. Z-Good-First-Issue Good for newcomers

Comments

@auscompgeek
Copy link
Contributor

If I send a multiline Matrix message, the bridged message on Slack is missing the first newline in the message. If there are multiple newlines, only the first disappears.

@Half-Shot Half-Shot added the bug label Mar 18, 2020
@Cadair
Copy link
Collaborator

Cadair commented Sep 28, 2020

I can't reproduce this but sending a message with only a single line break ends up stripping that line break.

@Cadair Cadair added good first issue hacktoberfest Good issues for people to tackle as part of hacktoberfest substitutions An issue relating to translation of event content between Slack and Matrix. labels Sep 28, 2020
@Cadair
Copy link
Collaborator

Cadair commented Sep 28, 2020

oh I can repro this, I misread the bug.

@stephen304
Copy link

I'm not sure if this is related, but no newlines in slack go through to matrix:

{
  "content": {
    "body": "1\n2\n3",
    "format": "org.matrix.custom.html",
    "formatted_body": "1\n2\n3",
    "msgtype": "m.text"
  },
  "origin_server_ts": ,
  "sender": "@_slack_...",
  "type": "m.room.message",
  "unsigned": {
    "age": 268
  },
  "event_id": "",
  "room_id": ""
}

But everything is on the same line in matrix.

When I send from matrix it of course shows up properly, the message source doesn't look that different. It's \n in both.

{
  "content": {
    "body": "1\n2\n3",
    "msgtype": "m.text"
  },
  "origin_server_ts": ,
  "sender": "@Stephen304:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 200,
    "transaction_id": ""
  },
  "event_id": "",
  "room_id": ""
}

@auscompgeek
Copy link
Contributor Author

I'm not sure if this is related, but no newlines in slack go through to matrix:

That's #547.

@jaller94 jaller94 added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. Z-Good-First-Issue Good for newcomers and removed bug labels May 16, 2022
@tadzik
Copy link
Contributor

tadzik commented Apr 4, 2024

(Will be) fixed in #781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Good issues for people to tackle as part of hacktoberfest substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. Z-Good-First-Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants