Skip to content

Commit

Permalink
Merge pull request #735 from matrix-org/justinbot/fix-lint
Browse files Browse the repository at this point in the history
Fix lint errors and run CI on all pull requests
  • Loading branch information
justinbot authored Mar 3, 2023
2 parents aa18240 + 46366cc commit 00c735c
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 11 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ develop ]
pull_request:
branches: [ develop ]

jobs:
lint:
Expand All @@ -16,4 +15,4 @@ jobs:
with:
node-version: 16
- run: yarn --ignore-scripts --pure-lockfile --strict-semver
- run: yarn lint
- run: yarn lint
1 change: 0 additions & 1 deletion .github/workflows/newsfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Newsfile

on:
pull_request:
branches: [ develop ]
workflow_dispatch:

jobs:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ develop ]
pull_request:
branches: [ develop ]

jobs:
unit:
Expand Down Expand Up @@ -53,4 +52,4 @@ jobs:
--env POSTGRES_PASSWORD=pass \
--env POSTGRES_INITDB_ARGS="--lc-collate C --lc-ctype C --encoding UTF8" \
postgres:11
- run: yarn test:postgres
- run: yarn test:postgres
1 change: 1 addition & 0 deletions changelog.d/734.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a new UI widget for linking and unlinking channels from within a Matrix room.
1 change: 1 addition & 0 deletions changelog.d/735.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a new UI widget for linking and unlinking channels from within a Matrix room.
2 changes: 1 addition & 1 deletion widget/src/SlackApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ const Unlinked = ({
/>
</>;
} else if (error) {
content = <Alerts.Warning><Text.Caption>{ error }</Text.Caption></Alerts.Warning>
content = <Alerts.Warning><Text.Caption>{ error }</Text.Caption></Alerts.Warning>;
} else {
content = <Text.Caption className="text-grey-200">Loading...</Text.Caption>;
}
Expand Down
4 changes: 2 additions & 2 deletions widget/src/components/icons/Alert.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react'
import { SVGProps } from 'react'
import * as React from 'react';
import { SVGProps } from 'react';

export const Alert = (props: SVGProps<SVGSVGElement>) => (
<svg
Expand Down
6 changes: 3 additions & 3 deletions widget/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import ReactDOM from 'react-dom/client'
import React from 'react';
import ReactDOM from 'react-dom/client';

import App from './App'
import App from './App';
import './styles/index.css';

ReactDOM.createRoot(document.getElementById('root') as HTMLElement).render(
Expand Down

0 comments on commit 00c735c

Please sign in to comment.