Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable/disable language specific tests #28

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Mar 18, 2024

Previously some tests would run rust/js tests regardless of what the test matrix env var said. Now we always look at it to determine if we should run a test.

Fixes #24

@kegsay kegsay requested a review from andybalaam March 18, 2024 14:53
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; some questions.

ENVIRONMENT.md Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
tests/federation_connectivity_test.go Outdated Show resolved Hide resolved
tests/federation_connectivity_test.go Show resolved Hide resolved
tests/federation_connectivity_test.go Show resolved Hide resolved
@kegsay kegsay merged commit aeb638e into main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect if rust / js only tests should be run
2 participants