Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for 'The room key is cycled when rotation_period_msgs is met' #16

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add a test for 'The room key is cycled when rotation_period_msgs is met' #16

merged 3 commits into from
Mar 8, 2024

Conversation

andybalaam
Copy link
Contributor

Closes #15

andybalaam
andybalaam commented Mar 1, 2024
View reviewed changes
tests/room_keys_test.go

tc.WithAliceAndBobSyncing(t, func(alice, bob api.Client) {
// And some messages were sent, but not enough to trigger resending
for i := 0; i < 4; i++ {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested in whether we can verify that no keys are sent before we hit the threshold.

@andybalaam andybalaam assigned andybalaam and unassigned andybalaam Mar 1, 2024
@andybalaam andybalaam force-pushed the andybalaam/test-retrying-device-key-download branch from 3c49b2a to dd5c581 Compare March 4, 2024 10:20
@andybalaam
Copy link
Contributor Author

Rebased on top of latest

@andybalaam andybalaam requested a review from kegsay March 4, 2024 10:20
@andybalaam
Copy link
Contributor Author

@kegsay

Did I break your new test or is it somehow flaky?


❌ TestUnprocessedToDeviceMessagesArentLostOnRestart (21.24s)
✅ TestUnprocessedToDeviceMessagesArentLostOnRestart/js (8.18s)
❌ TestUnprocessedToDeviceMessagesArentLostOnRestart/rust (13.06s)

@andybalaam
Copy link
Contributor Author

I am seeing this locally:

panic: Log in goroutine after TestUnprocessedToDeviceMessagesArentLostOnRestart/js h
as completed: [@user-146-bob:hs1](js) StartSyncing now syncing\n

@andybalaam
Copy link
Contributor Author

I get the same error locally if I revert my change.

@andybalaam andybalaam force-pushed the andybalaam/test-retrying-device-key-download branch from dd5c581 to d5ae5ff Compare March 4, 2024 11:54
@andybalaam
Copy link
Contributor Author

Rebased on top of the fix for ^

kegsay
kegsay requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

tests/main_test.go Outdated Show resolved Hide resolved
tests/room_keys_test.go Show resolved Hide resolved
tests/room_keys_test.go Outdated Show resolved Hide resolved
@andybalaam andybalaam requested a review from kegsay March 6, 2024 16:16
kegsay
kegsay approved these changes Mar 6, 2024
View reviewed changes
tests/to_device_test.go Show resolved Hide resolved
tests/main_test.go Outdated Show resolved Hide resolved
tests/main_test.go Outdated Show resolved Hide resolved
tests/main_test.go Show resolved Hide resolved
kegsay
kegsay approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andybalaam andybalaam force-pushed the andybalaam/test-retrying-device-key-download branch from 71ea92a to 87d7ca2 Compare March 8, 2024 09:52
@andybalaam andybalaam merged commit 58366d4 into main Mar 8, 2024
2 checks passed
@andybalaam andybalaam deleted the andybalaam/test-retrying-device-key-download branch March 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test "The room key is cycled when rotation_period_msgs is met"
2 participants
@andybalaam @kegsay