Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the rust.go code to the changes in FFI bindings #137

Closed
wants to merge 1 commit into from

Conversation

jmartinesp
Copy link
Contributor

This PR will change how EventTimelineItem and other structs related to it are exposed in the bindings, effectively breaking the Go bindings used in this repo.

With these changes the tests pass again, but please let me know if there's anything wrong since I'm not very familiar with Go.

@jmartinesp
Copy link
Contributor Author

Is there a way to make the checks point to the unmerged branch so we can verify they're ok?

@kegsay
Copy link
Member

kegsay commented Sep 25, 2024

You need to call the branch names the same thing:

++ curl -s -o /dev/null -w '%{http_code}' https://api.github.com/repos/matrix-org/matrix-rust-sdk/branches/misc/timeline-event-ffi-object-to-record
+ response=404

The linked PR has the branch name test/jme/timeline-event-ffi-object-to-record

@jmartinesp
Copy link
Contributor Author

jmartinesp commented Sep 25, 2024

Ah damn it, I changed the branch name to avoid the test/ prefix... I'll close the PR and create a new one then, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants