bugfix: don't risk logging in finished tests

matrix-org · Mar 4, 2024 · 4c8fae0 · 4c8fae0
1 parent 21d682d
commit 4c8fae0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/api/js/js.go b/internal/api/js/js.go
@@ -447,8 +447,8 @@ func (c *JSClient) Logf(t ct.TestLike, format string, args ...interface{}) {
 	formatted := fmt.Sprintf(t.Name()+": "+format, args...)
 	if c.browser.Ctx.Err() == nil { // don't log on dead browsers
 		chrome.MustRunAsyncFn[chrome.Void](t, c.browser.Ctx, fmt.Sprintf(`console.log("%s");`, strings.Replace(formatted, `"`, `\"`, -1)))
+		t.Logf(format, args...)
 	}
-	t.Logf(format, args...)
 }
 
 func (c *JSClient) Type() api.ClientTypeLang {