Skip to content

Commit

Permalink
Fix THDi percentage
Browse files Browse the repository at this point in the history
  • Loading branch information
mathieucarbou committed Jan 28, 2025
1 parent 71e2c0e commit 3e2325e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/MycilaRouter/MycilaRouter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void Mycila::Router::getRouterMetrics(Metrics& metrics, float voltage) const {

metrics.powerFactor = metrics.apparentPower == 0 ? NAN : metrics.power / metrics.apparentPower;
metrics.resistance = metrics.current == 0 ? NAN : metrics.power / (metrics.current * metrics.current);
metrics.thdi = metrics.powerFactor == 0 ? NAN : std::sqrt(1.0f / (metrics.powerFactor * metrics.powerFactor) - 1.0f);
metrics.thdi = metrics.powerFactor == 0 ? NAN : 100.0f * std::sqrt(1.0f / (metrics.powerFactor * metrics.powerFactor) - 1.0f);

if (_localMetrics.isPresent()) {
metrics.energy = _localMetrics.get().energy;
Expand Down Expand Up @@ -117,7 +117,7 @@ void Mycila::Router::getRouterMeasurements(Metrics& metrics) const {

metrics.powerFactor = metrics.apparentPower == 0 ? NAN : metrics.power / metrics.apparentPower;
metrics.resistance = metrics.current == 0 ? NAN : metrics.power / (metrics.current * metrics.current);
metrics.thdi = metrics.powerFactor == 0 ? NAN : std::sqrt(1.0f / (metrics.powerFactor * metrics.powerFactor) - 1.0f);
metrics.thdi = metrics.powerFactor == 0 ? NAN : 100.0f * std::sqrt(1.0f / (metrics.powerFactor * metrics.powerFactor) - 1.0f);
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/MycilaRouter/MycilaRouterOutput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ void Mycila::RouterOutput::getOutputMetrics(Metrics& metrics, float gridVoltage)
metrics.dimmedVoltage = metrics.powerFactor * metrics.voltage;
metrics.current = metrics.resistance == 0 ? 0 : metrics.dimmedVoltage / metrics.resistance;
metrics.apparentPower = metrics.current * metrics.voltage;
metrics.thdi = dutyCycle == 0 ? 0 : std::sqrt(1 / dutyCycle - 1);
metrics.thdi = dutyCycle == 0 ? 0 : 100.0f * std::sqrt(1 / dutyCycle - 1);
}

bool Mycila::RouterOutput::getOutputMeasurements(Metrics& metrics) const {
Expand Down

0 comments on commit 3e2325e

Please sign in to comment.