Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset django migrations, document upgrade #4145

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Jan 21, 2025

This PR:

  • Resets the Django migrations completely
  • Adds documentation to help the user understand the implications of that migration reset, and help them "upgrade" from previous versions of Mathesar.

Technical details

The documentation walks the user through knocking out their old mathesar_django database, recreating it, and then proceeding with the upgrade.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer added the pr-status: review A PR awaiting review label Jan 21, 2025
@mathemancer mathemancer added this to the v0.2.0 (beta release) milestone Jan 21, 2025
@mathemancer
Copy link
Contributor Author

@kgodey You might want to read through the "upgrade" docs portion of this PR.

If you have a Docker compose installation (including one from the guided script), run the command below:

```
docker compose -f /etc/mathesar/docker-compose.yml up --pull always -d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathemancer We would be moving to a different repository in Docker i.e. mathesar/mathesar instead of mathesar/mathesar-prod, so this wouldn't work.

We would have to ask users to modify their docker-compose file or get the latest one from our repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I've made minor suggestions that needs your attention @mathemancer.

docs/docs/releases/0.2.0.md Outdated Show resolved Hide resolved
python manage.py compilemessages
```

1. Update Mathesar functions on the database:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't install/update any functions using install.py anymore, I am skeptical whether we even need this step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Removed!

@mathemancer
Copy link
Contributor Author

Okay, I'm going to merge this in interest of time. @kgodey We can add more docs updates to the release branch after it's cut.

@mathemancer mathemancer enabled auto-merge January 22, 2025 14:06
@mathemancer mathemancer added this pull request to the merge queue Jan 22, 2025
Merged via the queue into develop with commit df5cb88 Jan 22, 2025
74 checks passed
@mathemancer mathemancer deleted the reset_django_migrations branch January 22, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants