Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show
FutureWarning
andDeprecationWarning
forpytest
#4138base: master
Are you sure you want to change the base?
Show
FutureWarning
andDeprecationWarning
forpytest
#4138Changes from all commits
545e2a5
64c99d8
3a79e83
c213125
bc8d0ae
52348ea
0d697e9
35ad4ca
0aad506
0dd7e40
47bca8c
b4bee46
6a62d63
0dad00c
f693604
f84bfd3
4b92c08
1d9f673
bc5024f
846c5fa
a122ec9
bc755b2
8c1cee5
401df09
856bfc0
050bf49
d5a749d
2f54d9d
80d3d6a
96ff0e3
1ec42d9
6ed8a65
a1538f9
3dd3a3b
241621a
041c874
e4df7b3
e01dec6
e69e3f0
c9e4301
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure about this change (regarding the axis), but it should be the columns from the warning message:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not experienced with
plotly
, could any one help me confirm this?Looks like the correct colorbar for mesh3d:
pymatgen/src/pymatgen/analysis/wulff.py
Lines 575 to 589 in 0e65d35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some LAMMPS expert to fix this, this class has only one method but deprecated (the class itself is not):
pymatgen/src/pymatgen/io/lammps/inputs.py
Lines 963 to 977 in 0e65d35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaGeo would appreciate it if you could have a look at this as well, got:
And as per the manual:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this we get:
But this doesn't look like a in place replace, for:
I got 6 test failure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
central_diff_weights
should have been removed (but for some reason not yet), and the replacement is another package, comment this out for now?