Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc. MontyStore improvements #827

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

rkingsbury
Copy link
Collaborator

Assorted improvements to MontyStore prompted by #820 .

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (a0a0dd1) 88.13% compared to head (41b5a08) 88.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   88.13%   88.14%           
=======================================
  Files          44       44           
  Lines        3624     3627    +3     
=======================================
+ Hits         3194     3197    +3     
  Misses        430      430           
Impacted Files Coverage Δ
src/maggma/stores/mongolike.py 88.63% <90.90%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rkingsbury rkingsbury marked this pull request as ready for review July 21, 2023 02:11
@rkingsbury rkingsbury merged commit 2aab86b into materialsproject:main Jul 21, 2023
11 checks passed
@rkingsbury rkingsbury deleted the montybetter branch July 21, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

database_name of MontyStore doesn't seem to update the name
1 participant