Copy MDC-iOS' warnings. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be rationalized.
|
Are we intentionally disabling all of the |
jverkoey
suggested changes
Nov 16, 2017
strict_warnings_objc_library.bzl
Outdated
| # * Our basic warnings cover most things and make warnings into errors. | ||
| # * If a warning is (transitively) enabled by our basic warnings, do not include it separately. | ||
| # * For warnings not enabled by our basic warnings, add them to the extra warnings. | ||
| # * To change a warning-as-error into just a warning, add it to the ignorable warnings. |
There was a problem hiding this comment.
"...using the format -Wno-error=<warning>"
strict_warnings_objc_library.bzl
Outdated
| # * If a warning is (transitively) enabled by our basic warnings, do not include it separately. | ||
| # * For warnings not enabled by our basic warnings, add them to the extra warnings. | ||
| # * To change a warning-as-error into just a warning, add it to the ignorable warnings. | ||
| # * To disable a warning completely, add it to the disabled warnings. |
There was a problem hiding this comment.
"...using the format -Wno-<warning>"
|
No. |
|
Got it! |
|
Done, PTAL. |
…m to be supported by Kokoro?
jverkoey
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy material-components/material-components-ios#2456 until the warnings can be rationalized.