fix: correct behavior of checkboxes/radios in a list.

PiperOrigin-RevId: 524854269
material-components · Apr 17, 2023 · f771b09 · f771b09
1 parent a094dd9
commit f771b09
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/mdc-list/component.ts b/packages/mdc-list/component.ts
@@ -422,9 +422,7 @@ export class MDCList extends MDCComponent<MDCListFoundation> {
   private handleClickEvent(evt: MouseEvent) {
     const index = this.getListItemIndex(evt.target as Element);
     const target = evt.target as Element;
-    // Toggle the checkbox only if it's not the target of the event, or the
-    // checkbox will have 2 change events.
-    const toggleCheckbox = !matches(target, strings.CHECKBOX_RADIO_SELECTOR);
-    this.foundation.handleClick(index, toggleCheckbox, evt);
+    this.foundation.handleClick(
+        index, matches(target, strings.CHECKBOX_RADIO_SELECTOR), evt);
   }
 }
diff --git a/packages/mdc-list/test/component.test.ts b/packages/mdc-list/test/component.test.ts
@@ -437,7 +437,7 @@ describe('MDCList', () => {
         root.querySelector<HTMLElement>('.mdc-deprecated-list-item')!;
     listElementItem.dispatchEvent(event);
     expect(mockFoundation.handleClick)
-        .toHaveBeenCalledWith(0, true, jasmine.any(Event));
+        .toHaveBeenCalledWith(0, false, jasmine.any(Event));
     expect(mockFoundation.handleClick).toHaveBeenCalledTimes(1);
     document.body.removeChild(root);
   });