[TextInputLayout] Update text paddings in compound layouts uniformly #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -718,17 +716,6 @@ public TextInputLayout(@NonNull Context context, @Nullable AttributeSet attrs, i | |||
| setHelperText(helperText); | |||
| } | |||
|
|
|||
| @Override | |||
| public void onGlobalLayout() { | |||
There was a problem hiding this comment.
The OnGlobalLayoutListener was originally added in 93360a5 in order to prevent an onMeasure() infinite loop bug, wouldn't removing OnGlobalLayoutListener reintroduce that bug?
There was a problem hiding this comment.
I don't know about the bug, but the situation from the explanation shouldn't happen since endLayout.measure() for the visible endLayout is guaranteed to be called by super.onMeasure(), which is before updateDummyDrawables().
Open
pubiqq
force-pushed
the
textinputlayout/uniform-text-padding-measuring
branch
from
19e7163
to
fb8b58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4231, most likely fixes #3869 and fixes #3993.