add task solution #2617
Open
add task solution #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 1, 2024
src/components/Person/Person.jsx
Outdated
Comment on lines
5
to
7
| {person.isMarried ? ( | ||
| <p className="Person__partner"> | ||
| {person.partnerName} is my {person.sex === 'f' ? 'husband' : 'wife'} |
There was a problem hiding this comment.
nested ternary operators are a bad practice
decide before jsx what text will be rendered and just render in jsx. something like that
const personPartnerType = sex === 'm' ? 'wife' : 'husband';
const personPartner = isMarried ? `${partnerName} is my ${personPartnerType}` : 'I am not married'
anastasiiavorobiova
suggested changes
Oct 1, 2024
| @@ -1 +1,17 @@ | |||
| // export const Person = ({ person }) => (); | |||
| export const Person = ({ person }) => { | |||
There was a problem hiding this comment.
Consider using destructuring here
src/components/Person/Person.jsx
Outdated
Comment on lines
6
to
8
| <h2 className="Person__name">{`My name is ${person.name}`}</h2> | ||
| {person.age && <p className="Person__age">I am {person.age}</p>} | ||
| {person.isMarried ? ( |
There was a problem hiding this comment.
Suggested change
| <h2 className="Person__name">{`My name is ${person.name}`}</h2> | |
| {person.age && <p className="Person__age">I am {person.age}</p>} | |
| {person.isMarried ? ( | |
| <h2 className="Person__name">{`My name is ${name}`}</h2> | |
| {age && <p className="Person__age">I am {age}</p>} | |
| {isMarried ? ( |
etojeDenys
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://Ren6436.github.io/react_person/