Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1642

wants to merge 2 commits into from

Conversation

voronine
Copy link

Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there is quite a bit of work to be done.

src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Outdated Show resolved Hide resolved
src/components/Person/Person.jsx Show resolved Hide resolved
src/components/Person/Person.jsx Show resolved Hide resolved
Copy link

@annak1104 annak1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!


const MAN = 'm';
const WIFE = 'wife';
const HUSBANT = 'husband';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const HUSBANT = 'husband';
const HUSBAND = 'husband';


return (
<section className="Person">
<h2 className="Person__name">{`My name is ${name}`}</h2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2 className="Person__name">{`My name is ${name}`}</h2>
<h2 className="Person__name">
{`My name is ${name}`}
</h2>

Comment on lines +24 to +28
{age > 0
&& (
<p className="Person__age">{`I am ${age}`}</p>
)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{age > 0
&& (
<p className="Person__age">{`I am ${age}`}</p>
)
}
{age > 0 && (
<p className="Person__age">
{`I am ${age}`}
</p>
)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants