react_person solution #1631
Open
react_person solution #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
suggested changes
Aug 23, 2023
src/App.jsx
Outdated
| <p className="Person__age">I am 37</p> | ||
| <p className="Person__partner">Natasha is my wife</p> | ||
| </section> | ||
| <Person person={misha} /> | ||
|
|
There was a problem hiding this comment.
Delete blank lines between components
src/components/Person/Person.jsx
Outdated
| return ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name"> | ||
| {`My name is ${person.name}`} |
src/components/Person/Person.jsx
Outdated
| {`My name is ${person.name}`} | ||
| </h2> | ||
|
|
||
| {Boolean(person.age) > 0 && ( |
There was a problem hiding this comment.
Suggested change
| {Boolean(person.age) > 0 && ( | |
| {Boolean(person.age) && ( |
src/components/Person/Person.jsx
Outdated
| </p> | ||
| )} | ||
|
|
||
| <p className="Person__partner">{marriageInformation}</p> |
There was a problem hiding this comment.
Suggested change
| <p className="Person__partner">{marriageInformation}</p> | |
| <p className="Person__partner"> | |
| {marriageInformation} | |
| </p> |
roman-mirzoian
approved these changes
Aug 23, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
6
to
8
| const spouseGender = sex === 'm' | ||
| ? 'wife' | ||
| : 'husband'; |
There was a problem hiding this comment.
It would be cool to keep such data in separate constants:
const MALE = 'm';
const WIFE = 'wife';
const HUSBAND = 'husband';
...
const spouseGender = sex === MALE
? WIFE
: HUSABAND;There was a problem hiding this comment.
oh, I really didn't see it, sorry, I'll redo it now, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK: https://Vitalii-Petruk.github.io/react_person/