finish solution #1619
Open
finish solution #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anna-Tkachenko
requested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
|
|
||
| export const Person = (props) => { | ||
| const { name, age, sex, isMarried, partnerName } = props.person; | ||
| let partner = `I am not married`; |
There was a problem hiding this comment.
It's not clear why not marriage info string is stored in partner variable
Check please variable name
src/components/Person/Person.jsx
Outdated
Comment on lines
20
to
22
| {age | ||
| ? <p className="Person__age">{`I am ${age}`}</p> | ||
| : null } |
There was a problem hiding this comment.
It's redundant to use null here
Rewrite it using && operator
Moroz-Dmytro
suggested changes
Aug 25, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
5
to
6
| export const Person = (props) => { | ||
| const { name, age, sex, isMarried, partnerName } = props.person; |
There was a problem hiding this comment.
Suggested change
| export const Person = (props) => { | |
| const { name, age, sex, isMarried, partnerName } = props.person; | |
| export const Person = ({ person }) => { | |
| const { | |
| name, | |
| age, | |
| sex, | |
| isMarried, | |
| partnerName, | |
| } = person; |
There was a problem hiding this comment.
We can use destructuring for props. Also pay attention to good formatting
src/components/Person/Person.jsx
Outdated
Comment on lines
19
to
20
| </h2> | ||
| {age && <p className="Person__age">{`I am ${age}`}</p>} |
There was a problem hiding this comment.
Suggested change
| </h2> | |
| {age && <p className="Person__age">{`I am ${age}`}</p>} | |
| </h2> | |
| {!!age && ( | |
| <p className="Person__age"> | |
| {`I am ${age}`} | |
| </p> | |
| } |
There was a problem hiding this comment.
It is easier to read. Also if age=0 we will see 0 on the page. !! solves this problem
| {`My name is ${name}`} | ||
| </h2> | ||
| {age && <p className="Person__age">{`I am ${age}`}</p>} | ||
| <p className="Person__partner"> |
There was a problem hiding this comment.
Suggested change
| <p className="Person__partner"> | |
| <p className="Person__partner"> |
Moroz-Dmytro
approved these changes
Aug 25, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
25
to
26
| </h2> | ||
| {!!age && ( |
There was a problem hiding this comment.
Suggested change
| </h2> | |
| {!!age && ( | |
| </h2> | |
| {!!age && ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo link