-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1618
base: master
Are you sure you want to change the base?
solution #1618
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1 +1,36 @@ | ||||||||||
// export const Person = ({ person }) => (); | ||||||||||
export const Person = ({ person }) => { | ||||||||||
const { | ||||||||||
name, | ||||||||||
age, | ||||||||||
sex, | ||||||||||
isMarried, | ||||||||||
partnerName, | ||||||||||
} = person; | ||||||||||
|
||||||||||
const getPartner = () => { | ||||||||||
if (isMarried) { | ||||||||||
return sex === 'm' | ||||||||||
? 'wife' | ||||||||||
: 'husband'; | ||||||||||
} | ||||||||||
|
||||||||||
return 'I am not married'; | ||||||||||
}; | ||||||||||
|
||||||||||
return ( | ||||||||||
<section className="Person"> | ||||||||||
<h2 className="Person__name"> | ||||||||||
{`My name is ${name}`} | ||||||||||
</h2> | ||||||||||
|
||||||||||
{age && <p className="Person__age">{`I am ${age}`}</p>} | ||||||||||
|
||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
<p className="Person__partner"> | ||||||||||
{partnerName | ||||||||||
? `${partnerName} is my ${getPartner()}` | ||||||||||
: getPartner() | ||||||||||
} | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think will be better to refactor this solution and remove Instead of calling |
||||||||||
</p> | ||||||||||
</section> | ||||||||||
); | ||||||||||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'I'm not married' doesn't sound like partner, I'd prefer to create variable and use ternary