-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sol #1617
base: master
Are you sure you want to change the base?
sol #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Needs some imrovements.
src/components/Person/Person.jsx
Outdated
{person.age === undefined | ||
? null | ||
: <p className="Person__age">{`I am ${person.age}`}</p> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{person.age === undefined | |
? null | |
: <p className="Person__age">{`I am ${person.age}`}</p> } | |
{person.age && ( | |
<p className="Person__age">{`I am ${person.age}`}</p> | |
)} |
src/components/Person/Person.jsx
Outdated
if (!person.isMarried) { | ||
content | ||
= ( | ||
<p className="Person__partner"> | ||
`I am not married` | ||
</p> | ||
); | ||
} else if (person.sex === 'm') { | ||
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>; | ||
} else { | ||
content | ||
= ( | ||
<p className="Person__partner"> | ||
{`${person.partnerName} is my husband`} | ||
</p> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant else if.
enough to make a couple teranry and only for text.
const personPartnerType = sex === 'm' : 'wire' : 'husband';
const personParner = isMarried
? `${person.partnerName} is my ${personPartnerType}`
: 'I am not married'
and use personPartner in jsx
src/components/Person/Person.jsx
Outdated
if (!person.isMarried) { | ||
content | ||
= ( | ||
<p className="Person__partner"> | ||
`I am not married` | ||
</p> | ||
); | ||
} else if (person.sex === 'm') { | ||
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>; | ||
} else { | ||
content | ||
= ( | ||
<p className="Person__partner"> | ||
{`${person.partnerName} is my husband`} | ||
</p> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant else if.
enough to make a couple teranry and only for text.
if (!person.isMarried) { | |
content | |
= ( | |
<p className="Person__partner"> | |
`I am not married` | |
</p> | |
); | |
} else if (person.sex === 'm') { | |
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>; | |
} else { | |
content | |
= ( | |
<p className="Person__partner"> | |
{`${person.partnerName} is my husband`} | |
</p> | |
); | |
} | |
const personPartnerType = sex === 'm' : 'wire' : 'husband'; | |
const personParner = isMarried | |
? `${person.partnerName} is my ${personPartnerType}` | |
: 'I am not married' |
and use personPartner in jsx
@@ -1 +1,31 @@ | |||
// export const Person = ({ person }) => (); | |||
export const Person = ({ person }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
destructure person.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DEMO LINK