Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sol #1617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sol #1617

wants to merge 2 commits into from

Conversation

VolodimirKurhan
Copy link

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some imrovements.

Comment on lines 25 to 27
{person.age === undefined
? null
: <p className="Person__age">{`I am ${person.age}`}</p> }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{person.age === undefined
? null
: <p className="Person__age">{`I am ${person.age}`}</p> }
{person.age && (
<p className="Person__age">{`I am ${person.age}`}</p>
)}

Comment on lines 4 to 20
if (!person.isMarried) {
content
= (
<p className="Person__partner">
`I am not married`
</p>
);
} else if (person.sex === 'm') {
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>;
} else {
content
= (
<p className="Person__partner">
{`${person.partnerName} is my husband`}
</p>
);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant else if.
enough to make a couple teranry and only for text.

const personPartnerType = sex === 'm' : 'wire' : 'husband';
const personParner = isMarried
  ? `${person.partnerName} is my ${personPartnerType}`
  : 'I am not married'

and use personPartner in jsx

Comment on lines 4 to 20
if (!person.isMarried) {
content
= (
<p className="Person__partner">
`I am not married`
</p>
);
} else if (person.sex === 'm') {
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>;
} else {
content
= (
<p className="Person__partner">
{`${person.partnerName} is my husband`}
</p>
);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant else if.
enough to make a couple teranry and only for text.

Suggested change
if (!person.isMarried) {
content
= (
<p className="Person__partner">
`I am not married`
</p>
);
} else if (person.sex === 'm') {
content = <p className="Person__partner">{`${person.partnerName} is my wife`}</p>;
} else {
content
= (
<p className="Person__partner">
{`${person.partnerName} is my husband`}
</p>
);
}
const personPartnerType = sex === 'm' : 'wire' : 'husband';
const personParner = isMarried
? `${person.partnerName} is my ${personPartnerType}`
: 'I am not married'

and use personPartner in jsx

@@ -1 +1,31 @@
// export const Person = ({ person }) => ();
export const Person = ({ person }) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

destructure person.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants