-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #1616
base: master
Are you sure you want to change the base?
add task solution #1616
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,3 @@ | ||
iframe { | ||
display: none; | ||
} | ||
|
||
.Person { | ||
width: fit-content; | ||
margin-bottom: 16px; | ||
padding: 8px; | ||
border: 1px solid #000; | ||
border-radius: 8px; | ||
|
||
&__name { | ||
margin-top: 8px; | ||
} | ||
|
||
&__age { | ||
color: #00f; | ||
font-weight: bold; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,44 @@ | ||
// export const Person = ({ person }) => (); | ||
import './Person.scss'; | ||
|
||
export const Person = ({ person }) => { | ||
const WOMAN_GENDER = 'f'; | ||
const MAN_GENDER = 'm'; | ||
|
||
const { | ||
name, | ||
age, | ||
isMarried, | ||
sex, | ||
partnerName, | ||
} = person; | ||
|
||
function getMarriedInfo() { | ||
if (sex === MAN_GENDER && isMarried) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Such a function can also be taken outside the component definition. |
||
return <>{`${partnerName} is my wife`}</>; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need to wrap everything in a fragment here? |
||
|
||
if (sex === WOMAN_GENDER && isMarried) { | ||
return <>{`${partnerName} is my husband`}</>; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need to wrap everything in a fragment here? |
||
|
||
return <>I am not married</>; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need to wrap everything in a fragment here? |
||
|
||
return ( | ||
<section className="Person"> | ||
<h2 className="Person__name">{`My name is ${name}`}</h2> | ||
|
||
<> | ||
{age && ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need to wrap everything in a fragment here? |
||
<p className="Person__age"> | ||
{`I am ${age}`} | ||
</p> | ||
)} | ||
</> | ||
|
||
<p className="Person__partner"> | ||
{getMarriedInfo()} | ||
</p> | ||
</section> | ||
); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
.Person { | ||
width: fit-content; | ||
margin-bottom: 16px; | ||
padding: 8px; | ||
border: 1px solid #000; | ||
border-radius: 8px; | ||
|
||
&__name { | ||
margin-top: 8px; | ||
} | ||
|
||
&__age { | ||
color: #00f; | ||
font-weight: bold; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such constants are better defined outside the component.